[ 
https://issues.apache.org/jira/browse/PHOENIX-1561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14269687#comment-14269687
 ] 

Brian Johnson commented on PHOENIX-1561:
----------------------------------------

Mostly I wanted to point out that in general the loaders don't strictly enforce 
these things and it's up to the end user to make sure they haven't done 
something that would violate the constraints. I don't see a problem with 
throwing exceptions, but there is no precedent for doing so.

> Pig optimized joins
> -------------------
>
>                 Key: PHOENIX-1561
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1561
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.2
>            Reporter: Brian Johnson
>            Assignee: Brian Johnson
>         Attachments: 0001-PHOENIX-1561-Optimizing-Joins.patch, patch
>
>
> PhoenixHBaseLoader should implement both OrderedLoadFunc and 
> CollectableLoadFunc just like HBaseStorage. There is nothing special that 
> needs to be done other than implementing a single method. As in HBaseStorage, 
> it is up to the user to ensure that the required constraints are not 
> violated. 
> {code:java}
>     public void ensureAllKeyInstancesInSameSplit() throws IOException {
>         /** 
>          * no-op because hbase keys are unique 
>          * This will also work with things like 
> DelimitedKeyPrefixRegionSplitPolicy
>          * if you need a partial key match to be included in the split
>          */
>         LOG.debug("ensureAllKeyInstancesInSameSplit");
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to