[
https://issues.apache.org/jira/browse/PHOENIX-1561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14316418#comment-14316418
]
Gabriel Reid commented on PHOENIX-1561:
---------------------------------------
I think the patch is good to go as is -- the suggestions that I had aren't
strictly needed, they're just intended to improve user friendliness. I think
two things still need to be done here:
1. Addition of a test case for OrderedLoadFunc ([~maghamraviki...@gmail.com]?)
2. Preferably a doc patch to specify the constraints to be followed by the user
when using optimized joins
> Pig optimized joins
> -------------------
>
> Key: PHOENIX-1561
> URL: https://issues.apache.org/jira/browse/PHOENIX-1561
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 4.2
> Reporter: Brian Johnson
> Assignee: Brian Johnson
> Attachments: 0001-PHOENIX-1561-Optimizing-Joins.patch, patch
>
>
> PhoenixHBaseLoader should implement both OrderedLoadFunc and
> CollectableLoadFunc just like HBaseStorage. There is nothing special that
> needs to be done other than implementing a single method. As in HBaseStorage,
> it is up to the user to ensure that the required constraints are not
> violated.
> {code:java}
> public void ensureAllKeyInstancesInSameSplit() throws IOException {
> /**
> * no-op because hbase keys are unique
> * This will also work with things like
> DelimitedKeyPrefixRegionSplitPolicy
> * if you need a partial key match to be included in the split
> */
> LOG.debug("ensureAllKeyInstancesInSameSplit");
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
