[
https://issues.apache.org/jira/browse/PHOENIX-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14271576#comment-14271576
]
James Taylor commented on PHOENIX-1409:
---------------------------------------
bq. This test suite is kinda unique in the sense that we are verifying hbase
level properties and hence we can't have overlapping table names for some tests.
How about if you generate a table name like this?
{code}
String tableName = ALTER_TABLE_BASE_NAME + nextTimestamp();
{code}
bq. The older test case is now covered under
testSetPropertyAndAddColumnForNewColumnFamily
Why not keep the existing test unchanged? Just copy/paste the old test and give
it a new name.
bq. The same behavior happens for ALTER TABLE too. Will add a test to verify
the same.
+1 after these minor changes.
Nice work, [~samarthjain] & [~ayingshu]!
> Allow ALTER TABLE <table> SET command to update HTableDescriptor and
> HColumnDescriptor properties
> -------------------------------------------------------------------------------------------------
>
> Key: PHOENIX-1409
> URL: https://issues.apache.org/jira/browse/PHOENIX-1409
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 4.2
> Reporter: James Taylor
> Assignee: Alicia Ying Shu
> Attachments: PHOENIX-1409-v3.patch, PHOENIX-1409-v6.patch,
> Phoenix-1409-v1.patch, Phoenix-1409-v4-2.patch, Phoenix-1409-v4.patch,
> Phoenix-1409-v5.patch, Phoenix-1409.patch, WIP.patch, phoenix-1409-v2.patch
>
>
> Once PHOENIX-1408 is fixed, we should allow HTableDescriptor and
> HColumnDescriptor properties through the ALTER TABLE <table> SET command.
> It'd just be a matter of passing these properties through the existing
> methods, as we support this for CREATE TABLE.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
