[ https://issues.apache.org/jira/browse/PHOENIX-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14264108#comment-14264108 ]
Alicia Ying Shu commented on PHOENIX-1409: ------------------------------------------ [~jamestaylor] Attached here a modified version of the patch. The main changes: 1) Removed Property class and used TableProperty enum instead to simplify the code. Defined validate() in TableProperty enum. 2). In my previous version, I already had the check to see whether HTableDescriptor is null or not in setTTLForNewColumnFamilies(). If null will get it again. Cannot move the check outside because it would failed if altering properties for views, etc. All mvn tests passed. > Allow ALTER TABLE <table> SET command to update HTableDescriptor and > HColumnDescriptor properties > ------------------------------------------------------------------------------------------------- > > Key: PHOENIX-1409 > URL: https://issues.apache.org/jira/browse/PHOENIX-1409 > Project: Phoenix > Issue Type: Improvement > Affects Versions: 4.2 > Reporter: James Taylor > Assignee: Alicia Ying Shu > Attachments: PHOENIX-1409-v3.patch, Phoenix-1409-v1.patch, > Phoenix-1409-v4-2.patch, Phoenix-1409-v4.patch, Phoenix-1409.patch, > WIP.patch, phoenix-1409-v2.patch > > > Once PHOENIX-1408 is fixed, we should allow HTableDescriptor and > HColumnDescriptor properties through the ALTER TABLE <table> SET command. > It'd just be a matter of passing these properties through the existing > methods, as we support this for CREATE TABLE. -- This message was sent by Atlassian JIRA (v6.3.4#6332)