[ https://issues.apache.org/jira/browse/PHOENIX-514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14278447#comment-14278447 ]
ASF GitHub Bot commented on PHOENIX-514: ---------------------------------------- Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/34#discussion_r22997186 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/index/IndexMaintainer.java --- @@ -883,6 +903,14 @@ public void readFields(DataInput input) throws IOException { dataEmptyKeyValueCF = Bytes.readByteArray(input); emptyKeyValueCFPtr = new ImmutableBytesPtr(Bytes.readByteArray(input)); + int numIndexedExpressions = WritableUtils.readVInt(input); + indexedExpressions = Sets.newLinkedHashSetWithExpectedSize(numIndexedExpressions); + for (int i = 0; i < numIndexedExpressions; i++) { --- End diff -- How does this interop with having a mix of pure data columns in the ON clause with functional expressions? The order is significant as far as I remember, so I think you'll want to have both in the same list. > Support functional indexes > -------------------------- > > Key: PHOENIX-514 > URL: https://issues.apache.org/jira/browse/PHOENIX-514 > Project: Phoenix > Issue Type: Task > Reporter: James Taylor > Assignee: Thomas D'Silva > Labels: enhancement > > Instead of only defining the set of columns from the data table that make up > an index, you should be able to use expressions. For example: > CREATE INDEX upper_last_name_idx ON person (UPPER(last_name)) > Then in queries that use UPPER(last_name), we can replace them with column > references to the index table. -- This message was sent by Atlassian JIRA (v6.3.4#6332)