[ 
https://issues.apache.org/jira/browse/PHOENIX-514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14294682#comment-14294682
 ] 

ASF GitHub Bot commented on PHOENIX-514:
----------------------------------------

Github user twdsilva commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/34#discussion_r23664456
  
    --- Diff: 
phoenix-core/src/main/java/org/apache/phoenix/compile/StatementContext.java ---
    @@ -98,11 +98,18 @@ public StatementContext(PhoenixStatement statement, 
ColumnResolver resolver, Sca
             this.aggregates = new AggregationManager();
             this.expressions = new ExpressionManager();
             PhoenixConnection connection = statement.getConnection();
    -        this.dateFormat = 
connection.getQueryServices().getProps().get(QueryServices.DATE_FORMAT_ATTRIB, 
DateUtil.DEFAULT_DATE_FORMAT);
    -        this.dateFormatTimeZone = TimeZone.getTimeZone(
    -                
connection.getQueryServices().getProps().get(QueryServices.DATE_FORMAT_TIMEZONE_ATTRIB,
 DateUtil.DEFAULT_TIME_ZONE_ID));
    +        if (connection!=null) {
    --- End diff --
    
    I have removed the null check.


> Support functional indexes
> --------------------------
>
>                 Key: PHOENIX-514
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-514
>             Project: Phoenix
>          Issue Type: Task
>            Reporter: James Taylor
>            Assignee: Thomas D'Silva
>              Labels: enhancement
>
> Instead of only defining the set of columns from the data table that make up 
> an index, you should be able to use expressions.  For example:
>       CREATE INDEX upper_last_name_idx ON person (UPPER(last_name))
> Then in queries that use UPPER(last_name), we can replace them with column 
> references to the index table.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to