Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/34#discussion_r23971716
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionObserver.java
---
@@ -270,7 +271,7 @@ protected RegionScanner doPostScannerOpen(final
ObserverContext<RegionCoprocesso
for (IndexMaintainer maintainer :
indexMaintainers) {
if (!results.isEmpty()) {
result.getKey(ptr);
- ValueGetter valueGetter =
maintainer.createGetterFromKeyValues(results);
+ ValueGetter valueGetter =
maintainer.createGetterFromKeyValues(new
ImmutableBytesPtr(ptr).copyBytesIfNecessary(),results);
--- End diff --
Minor, but no need to create a new ImmutableBytesWritable here
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
