Github user twdsilva commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/34#discussion_r23973403
  
    --- Diff: 
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
 ---
    @@ -630,6 +641,13 @@ private PTable getTable(RegionScanner scanner, long 
clientTimeStamp, long tableT
                     if (statsHTable != null) statsHTable.close();
                 }
             }
    +        // sort columns by ordinal position
    --- End diff --
    
    I had to add this because AlterTableIT.testDropIndexedColumn was failing 
for local indexes. 
    In  PTableImpl.init it looks like  allColumns is sorted, but pkColumns is 
not sorted. 
    Should I just move this into PTableImpl so that PK columns are sorted?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to