[ https://issues.apache.org/jira/browse/PHOENIX-1756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14370255#comment-14370255 ]
James Taylor commented on PHOENIX-1756: --------------------------------------- For Second(), wouldn't it be seconds of the hour you'd want? Either way, there's no need to instantiate a DateTime. You can just do a (epochMillisTime/1000) % 60, or (epochMillisTime/1000) % (24 * 60 * 60). Similar math for Minute() and Hour(). For Day(), I assume it's day of month, so you'd need to use DateTime for that. Might be better to name these more explicitly, as it wouldn't be clear what they return from the name. What does the SQL spec say is required? > Add Month() and Second() buildin functions > ------------------------------------------ > > Key: PHOENIX-1756 > URL: https://issues.apache.org/jira/browse/PHOENIX-1756 > Project: Phoenix > Issue Type: Improvement > Reporter: Alicia Ying Shu > Assignee: Alicia Ying Shu > Attachments: Phoenix-1756.patch > > > From Oracle doc: Month(date) and Second(date). Very similar to Year(date) > buildin. -- This message was sent by Atlassian JIRA (v6.3.4#6332)