Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/49#discussion_r26810919
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/hbase/index/IndexQosRpcControllerFactory.java
---
@@ -60,27 +61,22 @@ public PayloadCarryingRpcController
newController(List<CellScannable> cellIterab
private class IndexQosRpcController extends
DelegatingPayloadCarryingRpcController {
- private Configuration conf;
private int priority;
public IndexQosRpcController(PayloadCarryingRpcController
delegate, Configuration conf) {
super(delegate);
- this.conf = conf;
this.priority =
PhoenixIndexRpcSchedulerFactory.getMinPriority(conf);
}
-
@Override
public void setPriority(final TableName tn) {
// if its an index table, then we override to the index
priority
- if (isIndexTable(tn)) {
+ if (!tn.isSystemTable() &&
!PhoenixDatabaseMetaData.SYSTEM_TABLE_NAMES.contains(tn.getNameAsString())) {
--- End diff --
Actually, is it only SYSTEM.CATALOG that comes through here? How about if
we just check for that with Schema.isMetaTable(tn.getName())? It's possible
that we'd add an index to a system table down-the-road, so we may not want to
be too general with this check.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
