Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/49#discussion_r26819533
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/hbase/index/IndexQosRpcControllerFactory.java
---
@@ -60,27 +61,22 @@ public PayloadCarryingRpcController
newController(List<CellScannable> cellIterab
private class IndexQosRpcController extends
DelegatingPayloadCarryingRpcController {
- private Configuration conf;
private int priority;
public IndexQosRpcController(PayloadCarryingRpcController
delegate, Configuration conf) {
super(delegate);
- this.conf = conf;
this.priority =
PhoenixIndexRpcSchedulerFactory.getMinPriority(conf);
}
-
@Override
public void setPriority(final TableName tn) {
// if its an index table, then we override to the index
priority
- if (isIndexTable(tn)) {
+ if (!tn.isSystemTable() &&
!SchemaUtil.isSystemTable(tn.getName())) {
--- End diff --
Sorry to flip/flop on you, but I think the way you did it before was better
as if we end up adding indexes to system tables, they wouldn't set the priority
like we'd want them to.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
