Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/54#discussion_r27009308
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/parse/IndexExpressionParseNodeRewriter.java
---
@@ -51,6 +51,12 @@ public Void visit(ColumnParseNode node) throws
SQLException {
return null;
}
+ @Override
+ public boolean visitEnter(FunctionParseNode node) throws
SQLException {
--- End diff --
Is the intent of this visitor to determine if the indexed column is solely
a column name that's not case sensitive? Seems like you'd want to switch the
starting value in the constructor of isParseNodeCaseSensitive to true and then
only set it false in the visit(ColumnParseNode) if isTopLevel() is true (i.e.
it's the only expression in the tree) and the node isn't already case sensitive.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
