Github user twdsilva commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/54#discussion_r27065708
  
    --- Diff: 
phoenix-core/src/main/java/org/apache/phoenix/parse/IndexExpressionParseNodeRewriter.java
 ---
    @@ -51,6 +51,12 @@ public Void visit(ColumnParseNode node) throws 
SQLException {
                 return null;
             }
             
    +        @Override
    +        public boolean visitEnter(FunctionParseNode node) throws 
SQLException {
    +            isParseNodeCaseSensitive = true;
    --- End diff --
    
    I don't think there is a downside, in fact I think this is the correct 
behavior because when we create the index table we set we use a case sensitive 
version of the expressions string, so I think we always have to include the 
double quotes
    
    String name = expressionStr.replaceAll("\"", "'");
                            colName = 
ColumnName.caseSensitiveColumnName(IndexUtil.getIndexColumnName(null, name));


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to