[ 
https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14394890#comment-14394890
 ] 

Maryann Xue commented on PHOENIX-1580:
--------------------------------------

+1 to [~jamestaylor]'s comment "You shouldn't need the assertTrue(rs.next()) 
either". 
And remove that string comparison of your error message, I know you are 
wrappring the SQLFeatureNotSupportedException with RuntimeException coz you 
throw it from the parser (whose signature does not throw a declared Exception). 
Actually we should not throw the exception here, but never mind, I will fix the 
subquery support for union once this issue is checked in. So just remove the 
error message check as well as the "assertTrue(rs.next())".

> Support UNION ALL
> -----------------
>
>                 Key: PHOENIX-1580
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1580
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Alicia Ying Shu
>            Assignee: Alicia Ying Shu
>         Attachments: PHOENIX-1580-grammar.patch, Phoenix-1580-v1.patch, 
> Phoenix-1580-v2.patch, Phoenix-1580-v3.patch, Phoenix-1580-v4.patch, 
> Phoenix-1580-v5.patch, Phoenix-1580-v6.patch, Phoenix-1580-v7.patch, 
> Phoenix-1580-v8.patch, phoenix-1580-v1-wipe.patch, phoenix-1580.patch, 
> unionall-wipe.patch
>
>
> Select * from T1
> UNION ALL
> Select * from T2



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to