[
https://issues.apache.org/jira/browse/PHOENIX-1976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14548448#comment-14548448
]
Hudson commented on PHOENIX-1976:
---------------------------------
SUCCESS: Integrated in Phoenix-master #754 (See
[https://builds.apache.org/job/Phoenix-master/754/])
PHOENIX-1976 Exit gracefully if addShutdownHook fails. (ndimiduk: rev
23f5acf86e1065f6bc8c342df4ba29f18aafea8a)
* phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixDriver.java
> Improve PhoenixDriver registration when addShutdownHook fails
> -------------------------------------------------------------
>
> Key: PHOENIX-1976
> URL: https://issues.apache.org/jira/browse/PHOENIX-1976
> Project: Phoenix
> Issue Type: Bug
> Reporter: Josh Elser
> Assignee: Josh Elser
> Priority: Minor
> Fix For: 5.0.0, 4.5.0
>
> Attachments: PHOENIX-1976-master.patch
>
>
> Noticed this in running some tests. RegionServer was shutting down and
> MetaDataRegionObserver was just invoking {{postOpen}}
> When the {{Class.forName(PhoenixDriver.class.getName())}} gets called, the
> static initializer in {{PhoenixDriver}} gets invoked. Because the
> RegionServer is already stopping, the {{addShutdownHook}} fails with an
> {{IllegalArgumentException}}.
> It's not a _huge_ concern because we know the JVM is going down, but there
> are a few things we could handle better:
> * Ensure the PhoenixDriver gets closed if the shutdown hook fails to register
> * Avoid registering the PhoenixDriver instance if we're shutting down
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
