If it's committed to 4.x branches it should be fine as of now. On Tue, May 19, 2015 at 6:31 AM, Nick Dimiduk (JIRA) <[email protected]> wrote:
> > [ > https://issues.apache.org/jira/browse/PHOENIX-1976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14549598#comment-14549598 > ] > > Nick Dimiduk commented on PHOENIX-1976: > --------------------------------------- > > You want this for 4.4.1, [[email protected]]? Let me know where I > can apply it. Thanks. > > > Improve PhoenixDriver registration when addShutdownHook fails > > ------------------------------------------------------------- > > > > Key: PHOENIX-1976 > > URL: https://issues.apache.org/jira/browse/PHOENIX-1976 > > Project: Phoenix > > Issue Type: Bug > > Reporter: Josh Elser > > Assignee: Josh Elser > > Priority: Minor > > Fix For: 5.0.0, 4.5.0 > > > > Attachments: PHOENIX-1976-master.patch > > > > > > Noticed this in running some tests. RegionServer was shutting down and > MetaDataRegionObserver was just invoking {{postOpen}} > > When the {{Class.forName(PhoenixDriver.class.getName())}} gets called, > the static initializer in {{PhoenixDriver}} gets invoked. Because the > RegionServer is already stopping, the {{addShutdownHook}} fails with an > {{IllegalArgumentException}}. > > It's not a _huge_ concern because we know the JVM is going down, but > there are a few things we could handle better: > > * Ensure the PhoenixDriver gets closed if the shutdown hook fails to > register > > * Avoid registering the PhoenixDriver instance if we're shutting down > > > > -- > This message was sent by Atlassian JIRA > (v6.3.4#6332) >
