[ 
https://issues.apache.org/jira/browse/PHOENIX-1661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14604658#comment-14604658
 ] 

ASF GitHub Bot commented on PHOENIX-1661:
-----------------------------------------

GitHub user ictwanglei opened a pull request:

    https://github.com/apache/phoenix/pull/93

    PHOENIX-1661 Implement built-in functions for JSON

    1. Add some functional  files: JsonArrayElementsFunction.java  
JsonArrayLengthFunction.java JsonEachFunction.java  JsonObjectKeysFunction.java 
 JsonPopulateRecordFunction.java JsonPopulateRecordSetFunction.java. 
ArrayToJsonFunction.java
    
    2. Add a unit test file: JsonFunctionTest.java
    
    3. Modify file PhoenixJson.java to which I added some assistant functions.
    
    @JamesRTaylor @twdsilva @AakashPradeep please review the changelist.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ictwanglei/phoenix master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/phoenix/pull/93.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #93
    
----
commit 26383070e5980697a0de1193c069692a8107b7c2
Author: ictwanglei <597316...@qq.com>
Date:   2015-03-21T15:32:40Z

    Create ArrayToJsonFunction.java
    
    add a function to support "ArrayToJson" function as a build-in function for 
JSON

commit 2c63494f99267fbcd0b7e52be76a1dc0154e306a
Author: ictwanglei <597316...@qq.com>
Date:   2015-03-21T15:34:57Z

    Create ArrayToJsonFunctionTest.java
    
    a simple test for testing ArrayToJsonFunction

commit 241f4c3186a9f70f057e9196f962a0ed1b2f593b
Author: ictwanglei <597316...@qq.com>
Date:   2015-06-28T11:26:56Z

    Delete ArrayToJsonFunctionTest.java

commit f66ba90f92a667405759fceaf1ee74c27ef1d1c8
Author: ictwanglei <597316...@qq.com>
Date:   2015-06-28T11:35:37Z

    Create JsonFunctionTest.java

commit 7f2a6cf0c3d56b563a528036844dd5096f98ab6a
Author: ictwanglei <597316...@qq.com>
Date:   2015-06-28T11:53:44Z

    PHOENIX-1661
    
    Implement built-in functions for JSON

commit db5c9e1cfbb1f3145a992efef13a8dca7cee0ec7
Author: ictwanglei <597316...@qq.com>
Date:   2015-06-28T11:54:53Z

    Delete ArrayToJsonFunction.java

commit a02b954453ff67220c08801e0eafd1c23bdd4b9c
Author: ictwanglei <597316...@qq.com>
Date:   2015-06-28T11:55:10Z

    Rename ArrayToJsonFunction1.java to ArrayToJsonFunction.java

commit eb76667b0c61ea646a63c1b46b41f418c6b43239
Author: ictwanglei <597316...@qq.com>
Date:   2015-06-28T11:55:33Z

    Update ArrayToJsonFunction.java

commit 6546bc5fb0620b954e31e54e0c71671c54a8f9dc
Author: ictwanglei <597316...@qq.com>
Date:   2015-06-28T11:56:50Z

    PHOENIX-1661 Implement built-in functions for JSON

commit 6bb8b116db3dd46434f2020a0ca2f46545b0ac05
Author: ictwanglei <597316...@qq.com>
Date:   2015-06-28T11:58:22Z

    PHOENIX-1661 Implement built-in functions for JSON

commit 3782d70ce1c0fedbcea48e3df968564311c06a2a
Author: ictwanglei <597316...@qq.com>
Date:   2015-06-28T11:59:25Z

    PHOENIX-1661 Implement built-in functions for JSON

commit 5ff61520d2aa351ea4dab18ec131c74f34b1b463
Author: ictwanglei <597316...@qq.com>
Date:   2015-06-28T12:00:08Z

    PHOENIX-1661 Implement built-in functions for JSON

commit d21c22b3697b64b920cc22a33e32d76b2b8eb074
Author: ictwanglei <597316...@qq.com>
Date:   2015-06-28T12:01:14Z

    PHOENIX-1661 Implement built-in functions for JSON

commit 541697d72d27a809cb8172efd58d83960b79f362
Author: ictwanglei <597316...@qq.com>
Date:   2015-06-28T12:01:50Z

    PHOENIX-1661 Implement built-in functions for JSON

commit 7e0dbaf950b4292bf673bb64367e57085ada25f8
Author: ictwanglei <597316...@qq.com>
Date:   2015-06-28T12:03:16Z

    PHOENIX-1661 Implement built-in functions for JSON

commit 331e09b9df48611421830b3c52afc80fd75099d5
Author: ictwanglei <597316...@qq.com>
Date:   2015-06-28T12:09:54Z

    PHOENIX-1661 Implement built-in functions for JSON
    
    PHOENIX-1661 Implement built-in functions for JSON

----


> Implement built-in functions for JSON
> -------------------------------------
>
>                 Key: PHOENIX-1661
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1661
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>              Labels: JSON, Java, SQL, gsoc2015, mentor
>         Attachments: PhoenixJSONSpecification-First-Draft.pdf
>
>
> Take a look at the JSON built-in functions that are implemented in Postgres 
> (http://www.postgresql.org/docs/9.3/static/functions-json.html) and implement 
> the same for Phoenix in Java following this guide: 
> http://phoenix-hbase.blogspot.com/2013/04/how-to-add-your-own-built-in-function.html
> Examples of functions include ARRAY_TO_JSON, ROW_TO_JSON, TO_JSON, etc. The 
> implementation of these built-in functions will be impacted by how JSON is 
> stored in Phoenix. See PHOENIX-628. An initial implementation could work off 
> of a simple text-based JSON representation and then when a native JSON type 
> is implemented, they could be reworked to be more efficient.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to