[ 
https://issues.apache.org/jira/browse/PHOENIX-1661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14604780#comment-14604780
 ] 

ASF GitHub Bot commented on PHOENIX-1661:
-----------------------------------------

Github user AakashPradeep commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/93#discussion_r33424657
  
    --- Diff: 
phoenix-core/src/main/java/org/apache/phoenix/expression/function/ArrayToJsonFunction.java
 ---
    @@ -0,0 +1,87 @@
    +package org.apache.phoenix.expression.function;
    +
    +import org.apache.hadoop.hbase.io.ImmutableBytesWritable;
    +import org.apache.hadoop.hbase.util.Bytes;
    +import org.apache.phoenix.exception.SQLExceptionCode;
    +import org.apache.phoenix.exception.SQLExceptionInfo;
    +import org.apache.phoenix.expression.Expression;
    +import org.apache.phoenix.parse.FunctionParseNode;
    +import org.apache.phoenix.schema.IllegalDataException;
    +import org.apache.phoenix.schema.SortOrder;
    +import org.apache.phoenix.schema.json.PhoenixJson;
    +import org.apache.phoenix.schema.tuple.Tuple;
    +import org.apache.phoenix.schema.types.*;
    +import org.apache.phoenix.util.ByteUtil;
    +
    +import java.io.IOException;
    +import java.sql.SQLException;
    +import java.util.List;
    +
    +
    +@FunctionParseNode.BuiltInFunction(name=ArrayToJsonFunction.NAME,  args={
    +        @FunctionParseNode.Argument(allowedTypes={PVarchar.class})} )
    +public class ArrayToJsonFunction extends ScalarFunction {
    +    public static final String NAME = "Array_To_Json";
    --- End diff --
    
    Please use only capital letters for function name. I guess thats the 
general convention we are following for other functions  though I dont know 
whether it has any functional significance or not. 


> Implement built-in functions for JSON
> -------------------------------------
>
>                 Key: PHOENIX-1661
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1661
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>              Labels: JSON, Java, SQL, gsoc2015, mentor
>         Attachments: PhoenixJSONSpecification-First-Draft.pdf
>
>
> Take a look at the JSON built-in functions that are implemented in Postgres 
> (http://www.postgresql.org/docs/9.3/static/functions-json.html) and implement 
> the same for Phoenix in Java following this guide: 
> http://phoenix-hbase.blogspot.com/2013/04/how-to-add-your-own-built-in-function.html
> Examples of functions include ARRAY_TO_JSON, ROW_TO_JSON, TO_JSON, etc. The 
> implementation of these built-in functions will be impacted by how JSON is 
> stored in Phoenix. See PHOENIX-628. An initial implementation could work off 
> of a simple text-based JSON representation and then when a native JSON type 
> is implemented, they could be reworked to be more efficient.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to