[
https://issues.apache.org/jira/browse/PHOENIX-2058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14612597#comment-14612597
]
Thomas D'Silva commented on PHOENIX-2058:
-----------------------------------------
[~jamestaylor]
If a table has multiple views, and only *one* of the views has a column with
the same name that is being added to the base table, and if we can't add it to
the view (because lets say the data type is different), then we should not add
the column to the other views right?
Currently if a view is divorced we don't add new base table columns to the
divorced view, but we will add if there are other views that are not divorced
we add the column is that correct?
> Check for existence and compatibility of columns being added in view
> --------------------------------------------------------------------
>
> Key: PHOENIX-2058
> URL: https://issues.apache.org/jira/browse/PHOENIX-2058
> Project: Phoenix
> Issue Type: Bug
> Reporter: James Taylor
> Assignee: Thomas D'Silva
>
> One check I realized we're not doing, but need to do, is ensuring that the
> column being added by the base table doesn't already exist in the view. If
> the column does already exist, ideally we can allow the addition to the base
> table if the type matches and the scale is null or >= existing scale and the
> maxLength is null or >= existing maxLength. Also, if a column is a PK column
> and it already exists in the view, the position in the PK must match.
> The fact that we've materialized a PTable for the view should make the
> addition of this check easier.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
