[ 
https://issues.apache.org/jira/browse/PHOENIX-2058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14619655#comment-14619655
 ] 

Hudson commented on PHOENIX-2058:
---------------------------------

FAILURE: Integrated in Phoenix-master #821 (See 
[https://builds.apache.org/job/Phoenix-master/821/])
PHOENIX-2058 Check for existence and compatibility of columns being added in 
view (tdsilva: rev aa4c9003d4bd4827718e0f37de8c270f94fd5694)
* phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java


> Check for existence and compatibility of columns being added in view
> --------------------------------------------------------------------
>
>                 Key: PHOENIX-2058
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2058
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: Thomas D'Silva
>             Fix For: 5.0.0, 4.5.0
>
>         Attachments: PHOENIX-2058-WIP.patch, PHOENIX-2058.final.patch, 
> PHOENIX-2058.patch, PHOENIX-2058.v2.patch, PHOENIX-2058.wip.2.patch
>
>
> One check I realized we're not doing, but need to do, is ensuring that the 
> column being added by the base table doesn't already exist in the view. If 
> the column does already exist, ideally we can allow the addition to the base 
> table if the type matches and the scale is null or >= existing scale and the 
> maxLength is null or >= existing maxLength. Also, if a column is a PK column 
> and it already exists in the view, the position in the PK must match. 
> The fact that we've materialized a PTable for the view should make the 
> addition of this check easier.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to