[ 
https://issues.apache.org/jira/browse/PHOENIX-1673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14662518#comment-14662518
 ] 

ASF GitHub Bot commented on PHOENIX-1673:
-----------------------------------------

Github user elilevine commented on the pull request:

    https://github.com/apache/phoenix/pull/104#issuecomment-128840703
  
    The TENANT_ID column in system tables is used to quickly filter metadata 
belonging to a tenant. Agree we could probably get away with leaving it VARCHAR 
because that is how tenant ids are passed to connections anyway.
    
    Now that got me thinking... if we extending that logic further, why then do 
we need to implement support for other data types for tenant id columns if 
tenant ids are always passed in as strings to connections? Why not keep them 
all as VARCHAR/CHAR, like they are now?


> Allow tenant ID to be of any integral data type
> -----------------------------------------------
>
>                 Key: PHOENIX-1673
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1673
>             Project: Phoenix
>          Issue Type: Improvement
>    Affects Versions: 4.3.0
>            Reporter: Mark Tse
>              Labels: Newbie, multi-tenant
>             Fix For: 4.4.1
>
>
> When creating multi-tenant tables and views, the column that identifies the 
> tenant (first primary key column) must be of type 'VARCHAR' or 'CHAR'.
> It should be possible to relax this restriction to use any integral data 
> type. The tenant ID from the connection property can be converted based on 
> the data type of the first primary key column.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to