[
https://issues.apache.org/jira/browse/PHOENIX-1673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14680648#comment-14680648
]
ASF GitHub Bot commented on PHOENIX-1673:
-----------------------------------------
Github user elilevine commented on the pull request:
https://github.com/apache/phoenix/pull/104#issuecomment-129580603
Everything looks good in terms of code. Excellent work, @JeffreyLyonsD2L.
The only thing to figure out now is whether or not we should add the feature at
all. I agree that changing the schema of SYSTEM.* tables is off the table. So
do we allow the tenant id column in data tables to be of different type than in
metadata tables? It does not sit well with me and makes multi-tenancy seem
inconsistent IMHO, as I mentioned above, since tenant id is always passed in as
string to connections and is stored as such in system tables.
@JeffreyLyonsD2L, maybe you can shine some light on our use-case. You
mentioned that not having to do data conversion is a plus. In what way? Are you
starting with existing data and don't want to do data conversion?
> Allow tenant ID to be of any integral data type
> -----------------------------------------------
>
> Key: PHOENIX-1673
> URL: https://issues.apache.org/jira/browse/PHOENIX-1673
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 4.3.0
> Reporter: Mark Tse
> Labels: Newbie, multi-tenant
> Fix For: 4.4.1
>
>
> When creating multi-tenant tables and views, the column that identifies the
> tenant (first primary key column) must be of type 'VARCHAR' or 'CHAR'.
> It should be possible to relax this restriction to use any integral data
> type. The tenant ID from the connection property can be converted based on
> the data type of the first primary key column.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
