[ 
https://issues.apache.org/jira/browse/PHOENIX-1673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14681799#comment-14681799
 ] 

ASF GitHub Bot commented on PHOENIX-1673:
-----------------------------------------

Github user JeffreyLyonsD2L commented on the pull request:

    https://github.com/apache/phoenix/pull/104#issuecomment-129874512
  
    For points #1 and #3, I think I really mean converting the data we already 
have. We have a lot of data in our system with our current schema and would 
have to upgrade the entire schema and most of our historical data to fit the 
new standards, which for us would be a non-trivial process.
    
    We are also writing to the underlying tables through our own library, not 
through Phoenix, and that system is set up to have TenantId as an UNSIGNED_INT. 
This code is pretty ingrained in our system, and would require a massive 
refactor and significant restructure of how our cluster works to switch over to 
using something like fixed-length CHAR arrays.
    
    As for the tests, I'll get them up as soon as possible.


> Allow tenant ID to be of any integral data type
> -----------------------------------------------
>
>                 Key: PHOENIX-1673
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1673
>             Project: Phoenix
>          Issue Type: Improvement
>    Affects Versions: 4.3.0
>            Reporter: Mark Tse
>              Labels: Newbie, multi-tenant
>             Fix For: 4.4.1
>
>
> When creating multi-tenant tables and views, the column that identifies the 
> tenant (first primary key column) must be of type 'VARCHAR' or 'CHAR'.
> It should be possible to relax this restriction to use any integral data 
> type. The tenant ID from the connection property can be converted based on 
> the data type of the first primary key column.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to