[ https://issues.apache.org/jira/browse/PHOENIX-2299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15026717#comment-15026717 ]
Hadoop QA commented on PHOENIX-2299: ------------------------------------ {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12774326/0001-PHOENIX-2299-Support-CURRENT_DATE-in-Pherf-data-upse.patch against master branch at commit 1b5e7fd71f3709f760b008f7e458c124c2868594. ATTACHMENT ID: 12774326 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 10 new or modified tests. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:red}-1 javadoc{color}. The javadoc tool appears to have generated 32 warning messages. {color:red}-1 release audit{color}. The applied patch generated 1 release audit warnings (more than the master's current 0 warnings). {color:red}-1 lineLengths{color}. The patch introduces the following lines longer than 100: + String timeStamp = new SimpleDateFormat("yyyy-MM-dd HH:mm:ss.SSS z").format(Calendar.getInstance().getTime()); + String timeStamp1 = new SimpleDateFormat("yyyy-MM-dd HH:mm:ss.SSS z").format(Calendar.getInstance().getTime()); + String timeStamp2 = new SimpleDateFormat("yyyy-MM-dd HH:mm:ss.SSS z").format(Calendar.getInstance().getTime()); + if ((dataMapping.getType() == DataTypeMapping.DATE) && (dataMapping.getUseCurrentDate() == true)) { + String timeStamp1 = new SimpleDateFormat("yyyy-MM-dd HH:mm:ss.SSS z").format(Calendar.getInstance().getTime()); + assertNotNull("Could not retrieve a value in DataValue for random DATE.", value.getValue()); + String timeStamp2 = new SimpleDateFormat("yyyy-MM-dd HH:mm:ss.SSS z").format(Calendar.getInstance().getTime()); {color:red}-1 core tests{color}. The patch failed these unit tests: ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.TenantSpecificTablesDMLIT {color:red}-1 core zombie tests{color}. There are 1 zombie test(s): at org.apache.activemq.bugs.TransactedStoreUsageSuspendResumeTest.testTransactedStoreUsageSuspendResume(TransactedStoreUsageSuspendResumeTest.java:144) Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/185//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/185//artifact/patchprocess/patchReleaseAuditWarnings.txt Javadoc warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/185//artifact/patchprocess/patchJavadocWarnings.txt Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/185//console This message is automatically generated. > Support CURRENT_DATE() in Pherf data upserts > -------------------------------------------- > > Key: PHOENIX-2299 > URL: https://issues.apache.org/jira/browse/PHOENIX-2299 > Project: Phoenix > Issue Type: Improvement > Affects Versions: 4.6.0 > Reporter: James Taylor > Assignee: Karan Singhal > Labels: performance > Fix For: 4.6.0, 4.7.0 > > Attachments: > 0001-PHOENIX-2299-Support-CURRENT_DATE-in-Pherf-data-upse.patch > > > Just replace the actual date with "NOW" in the xml. Then check the string for > that value in the generator. -- This message was sent by Atlassian JIRA (v6.3.4#6332)