Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/135#discussion_r46096617
  
    --- Diff: 
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionObserver.java
 ---
    @@ -158,6 +162,10 @@ public RegionScanner 
preScannerOpen(ObserverContext<RegionCoprocessorEnvironment
                 throws IOException {
             s = super.preScannerOpen(e, scan, s);
             if (ScanUtil.isAnalyzeTable(scan)) {
    +            if (!ScanUtil.isLocalIndex(scan)) {
    +                scan.getFamilyMap().clear();
    +            }
    +
    --- End diff --
    
    That's a good idea, but how about we drive this from the client side 
instead? There's code in MetaDataClient.updateStatistics() that was adding the 
local index physical table (if stats on indexes are being updated). How about 
changing that to add the local index shadow column families?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to