Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/135#discussion_r46111265
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/UpsertCompiler.java ---
@@ -134,7 +143,36 @@ private static void setValues(byte[][] values, int[]
pkSlotIndex, int[] columnIn
}
}
ImmutableBytesPtr ptr = new ImmutableBytesPtr();
- table.newKey(ptr, pkValues);
+ if(table.getIndexType()==IndexType.LOCAL) {
--- End diff --
bq. so I don't think we should include this code.
Will remove in the next patch.
bq. We've talked about having a kind of "scrutiny" process that scans the
data table and ensures that all the corresponding indexes have the correct rows
(I filed PHOENIX-2460 for this).
+1 on this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
