[
https://issues.apache.org/jira/browse/PHOENIX-2464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15032454#comment-15032454
]
ASF GitHub Bot commented on PHOENIX-2464:
-----------------------------------------
Github user jmahonin commented on the pull request:
https://github.com/apache/phoenix/pull/137#issuecomment-160761094
Hi @gliptak
I tried to run the tests with the patch applied, and got a number of
failures. I think that 'beforeAll' and 'afterAll' aren't actually getting
invoked in with the JUnitSuite for some reason.
I tried adding the '@BeforeClass' and '@AfterClass' annotations, but JUnit
warns that the methods should be static. Sadly, I think the only way to make
that work is with a companion object (e.g. 'object PhoenixSparkIT' which
contains the beforeAll and afterAll definitions).
> phoenix-spark module should use 'JUnitSuite' instead of 'FunSuite'
> ------------------------------------------------------------------
>
> Key: PHOENIX-2464
> URL: https://issues.apache.org/jira/browse/PHOENIX-2464
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 4.6.0
> Reporter: Josh Mahonin
>
> The existing phoenix-spark tests use the 'FunSuite' from ScalaTest, but in
> order to properly inherit other JUnit annotations like '@ClassRules' from the
> base tests [1], it should be using 'JUnitSuite' instead.
> Issue exposed in PHOENX-2462
> [1] https://groups.google.com/forum/#!topic/scalatest-users/ayjVDbNiOas
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
