[
https://issues.apache.org/jira/browse/PHOENIX-2464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15032981#comment-15032981
]
ASF GitHub Bot commented on PHOENIX-2464:
-----------------------------------------
Github user jmahonin commented on the pull request:
https://github.com/apache/phoenix/pull/137#issuecomment-160831941
Definitely closer, it does run now, but it takes about 4x longer to run
than before. The 'doSetup' and 'doTeardown' used to be run only at the very
beginning and at the very end, and now they're being run before every test due
to the '@Before' and '@After' annotations.
I wonder if it's possible to do something like the 'ScalaClassRuleTest' in
[1] and either specify a '@BeforeAll' or an '@ClassRule' in a companion object
and move the 'doSetup' and 'doTeardown' there?
[1] http://randomallsorts.blogspot.ca/2012/11/junit-411-whats-new-rules.html
> phoenix-spark module should use 'JUnitSuite' instead of 'FunSuite'
> ------------------------------------------------------------------
>
> Key: PHOENIX-2464
> URL: https://issues.apache.org/jira/browse/PHOENIX-2464
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 4.6.0
> Reporter: Josh Mahonin
>
> The existing phoenix-spark tests use the 'FunSuite' from ScalaTest, but in
> order to properly inherit other JUnit annotations like '@ClassRules' from the
> base tests [1], it should be using 'JUnitSuite' instead.
> Issue exposed in PHOENX-2462
> [1] https://groups.google.com/forum/#!topic/scalatest-users/ayjVDbNiOas
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
