[
https://issues.apache.org/jira/browse/PHOENIX-1312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15061648#comment-15061648
]
James Taylor commented on PHOENIX-1312:
---------------------------------------
Nice work, [~ram_krish]. One minor nit: in BaseResultIterators, remove the
whereCondition != null check as you've already checked that it's not empty
earlier:
{code}
+ } else {
+ familyInWhere = whereConditions.iterator().next();
+ if(familyInWhere != null) {
{code}
+1 if all tests are passing.
> Do not always project the empty column family
> ---------------------------------------------
>
> Key: PHOENIX-1312
> URL: https://issues.apache.org/jira/browse/PHOENIX-1312
> Project: Phoenix
> Issue Type: Bug
> Reporter: James Taylor
> Assignee: ramkrishna.s.vasudevan
> Fix For: 4.7.0
>
> Attachments: PHOENIX-1312_1.patch, PHOENIX-1312_v2.patch,
> PHOENIX-1312_v3.patch, PHOENIX-1312_v4.patch, Phoenix-1312.patch
>
>
> Often times, we don't need to, but it seems we always are. See
> MultiCfQueryExecIT.testGuidePostsForMultiCFs() where we run a query like this:
> {code}
> SELECT count(*) FROM multi_cf WHERE e.cpu_utilization IS NOT NULL
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
