[
https://issues.apache.org/jira/browse/PHOENIX-1312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15062476#comment-15062476
]
Hadoop QA commented on PHOENIX-1312:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12778286/PHOENIX-1312_master.patch
against master branch at commit b38989dc7008e1f7568bb0146f669d95f0ca62bb.
ATTACHMENT ID: 12778286
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 7 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
33 warning messages.
{color:red}-1 release audit{color}. The applied patch generated 1 release
audit warnings (more than the master's current 0 warnings).
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ List<KeyRange> splits = getAllSplits(conn, "MULTI_CF",
"e.cpu_utilization IS NOT NULL", "COUNT(*)");
+ "CREATE TABLE T ( k INTEGER PRIMARY KEY, A.V1 VARCHAR,
B.V2 VARCHAR, C.V3 VARCHAR)");
+ NULL_EXPRESSION// Pass null expression because we don't want
empty key value to be projected
+ public static RowProjector compile(StatementContext context,
SelectStatement statement, GroupBy groupBy, List<? extends PDatum>
targetColumns, Expression where) throws SQLException {
+ isProjectEmptyKeyValue = where == null ||
LiteralExpression.isTrue(where) || where.requiresFinalEvaluation();
+ return new RowProjector(projectedColumns, estimatedByteSize,
isProjectEmptyKeyValue, resolver.hasUDFs(), isWildcard);
+ RowProjector projector = ProjectionCompiler.compile(context, select,
groupBy, asSubquery ? Collections.<PDatum>emptyList() : targetColumns, where);
+ this(projector.getColumnProjectors(),
projector.getEstimatedRowByteSize(), isProjectEmptyKeyValue, projector.hasUDFs,
projector.isProjectAll);
+ public RowProjector(List<? extends ColumnProjector> columnProjectors, int
estimatedRowSize, boolean isProjectEmptyKeyValue, boolean hasUDFs, boolean
isProjectAll) {
+ boolean keyOnlyFilter = familyMap.isEmpty() &&
context.getWhereConditionColumns().isEmpty();
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.TenantSpecificViewIndexIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/204//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/204//artifact/patchprocess/patchReleaseAuditWarnings.txt
Javadoc warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/204//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/204//console
This message is automatically generated.
> Do not always project the empty column family
> ---------------------------------------------
>
> Key: PHOENIX-1312
> URL: https://issues.apache.org/jira/browse/PHOENIX-1312
> Project: Phoenix
> Issue Type: Bug
> Reporter: James Taylor
> Assignee: ramkrishna.s.vasudevan
> Fix For: 4.7.0
>
> Attachments: PHOENIX-1312_1.patch, PHOENIX-1312_master.patch,
> PHOENIX-1312_v2.patch, PHOENIX-1312_v3.patch, PHOENIX-1312_v4.patch,
> Phoenix-1312.patch
>
>
> Often times, we don't need to, but it seems we always are. See
> MultiCfQueryExecIT.testGuidePostsForMultiCFs() where we run a query like this:
> {code}
> SELECT count(*) FROM multi_cf WHERE e.cpu_utilization IS NOT NULL
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
