[ 
https://issues.apache.org/jira/browse/PHOENIX-1261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15064792#comment-15064792
 ] 

Samarth Jain commented on PHOENIX-1261:
---------------------------------------

I thought it would be better to encapsulate all that logic in a Callable 
instead of just the commit stats call. Just to make the code more readable 
really. I needed to add the commit stats async config because tests were 
failing if I did the commit in an async fashion.

> Update stats table asynchronously
> ---------------------------------
>
>                 Key: PHOENIX-1261
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1261
>             Project: Phoenix
>          Issue Type: Sub-task
>            Reporter: James Taylor
>            Assignee: Samarth Jain
>             Fix For: 4.7.0
>
>         Attachments: 1261-wip.patch, PHOENIX-1261_master.patch
>
>
> Instead of writing the the stats table directly in the thread performing 
> major compaction, we should instead write to it asynchronously, perhaps using 
> the same asynchronous mechanism used by tracing. Apparently HBase used to 
> have a "custodian" table where they'd write as compaction and other 
> background tasks were running, and this leads to bad things happening if the 
> table being written to can't be reached.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to