[
https://issues.apache.org/jira/browse/PHOENIX-2605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15135382#comment-15135382
]
James Taylor commented on PHOENIX-2605:
---------------------------------------
Thanks, [~tdsilva]. Looks good. Couple of questions:
- does the rollback in MetaDataClient.buildIndex() need to be removed (it's not
needed as far as I can tell)? Otherwise the upsert select will start a new one,
no?
- should we use the full granularity ts since it's specifically for the tx case
and then we wouldn't need to convert it back to nanos?
- I assume we need that new is_data_table_txnl property? Not a huge deal, but
could we base that on the tx_scn property being non null?
- what's the scoop with the realDriver member variable you added to BaseTest?
We can't use the existing driver member variable?
> Enhance IndexToolIT to test transactional tables
> ------------------------------------------------
>
> Key: PHOENIX-2605
> URL: https://issues.apache.org/jira/browse/PHOENIX-2605
> Project: Phoenix
> Issue Type: Test
> Reporter: Thomas D'Silva
> Assignee: Thomas D'Silva
> Fix For: 4.7.0
>
> Attachments: PHOENIX-2605-v2.patch, PHOENIX-2605.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
