Github user maryannxue commented on the pull request:
https://github.com/apache/phoenix/pull/154#issuecomment-200637757
@ankitsinghal Thank you very much for the pull request! I am impressed by
how many details you have taken into account in your commit. It took me quite a
while to go through all of the changes. That said, it would be great if you
could add more test cases covering most (if not all) of the code changes, e.g.
the join case (left outer join w/ offset and w/wo limit), the derived table
case, the join with subquery case, etc.
Check JoinCompiler.isFlat(SelectStatement), it returns true only when limit
== null, think it should be the same for offset. That function is called when a
join contains a subquery, e.g. "select * from (select a, b from t1 offset 3)
join (select c, d from t2 limit 10)".
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
