Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/154#discussion_r57663883
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/DerivedTableIT.java ---
@@ -233,6 +233,34 @@ public void testDerivedTableWithWhere() throws
Exception {
assertEquals(9,rs.getInt(1));
assertFalse(rs.next());
+
+ // Inner limit < outer query offset
+ query = "SELECT t.eid, t.x + 9 FROM (SELECT entity_id eid,
b_string b, a_byte + 1 x FROM aTable LIMIT 1 OFFSET 1 ) AS t WHERE t.b = '"
+ + C_VALUE + "' OFFSET 2";
+ statement = conn.prepareStatement(query);
+ rs = statement.executeQuery();
+ assertFalse(rs.next());
+
+ // (offset) where
+ query = "SELECT t.eid, t.x + 9 FROM (SELECT entity_id eid,
b_string b, a_byte + 1 x FROM aTable WHERE a_byte + 1 < 9 OFFSET 2) AS t";
--- End diff --
This is (offset where) rather than (offset) where. I think it would make
more sense to test "(offset) where" here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
