Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/154#discussion_r58466741
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/QueryCompiler.java ---
@@ -168,7 +169,11 @@ public QueryPlan compileUnionAll(SelectStatement
select) throws SQLException {
SelectStatement subSelect = unionAllSelects.get(i);
// Push down order-by and limit into sub-selects.
if (!select.getOrderBy().isEmpty() || select.getLimit() !=
null) {
- subSelect = NODE_FACTORY.select(subSelect,
select.getOrderBy(), select.getLimit());
+ if (select.getOffset() == null) {
+ subSelect = NODE_FACTORY.select(subSelect,
select.getOrderBy(), select.getLimit(), null);
+ } else {
+ subSelect = NODE_FACTORY.select(subSelect,
select.getOrderBy(), null, null);
+ }
--- End diff --
Rather than this if statement, can we do the following to simplify it?
subSelect = NODE_FACTORY.select(subSelect, select.getOrderBy(),
select.getLimit(), select.getOffset())
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
