Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/154#discussion_r58467053
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/SubqueryRewriter.java ---
@@ -167,7 +167,7 @@ public ParseNode visitLeave(ExistsParseNode node,
List<ParseNode> l) throws SQLE
JoinConditionExtractor conditionExtractor = new
JoinConditionExtractor(subquery, resolver, connection, rhsTableAlias);
ParseNode where = subquery.getWhere() == null ? null :
subquery.getWhere().accept(conditionExtractor);
if (where == subquery.getWhere()) { // non-correlated EXISTS
subquery, add LIMIT 1
- subquery = NODE_FACTORY.select(subquery,
NODE_FACTORY.limit(NODE_FACTORY.literal(1)));
+ subquery = NODE_FACTORY.select(subquery,
NODE_FACTORY.limit(NODE_FACTORY.literal(1)), null);
--- End diff --
Always null here? Just want to confirm that this is correct.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
