Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58483863
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/TableResultIterator.java
---
@@ -80,13 +94,19 @@
};
- public TableResultIterator(MutationState mutationState, TableRef
tableRef, Scan scan, CombinableMetric scanMetrics, long renewLeaseThreshold)
throws SQLException {
+ public TableResultIterator(MutationState mutationState, Scan scan,
CombinableMetric scanMetrics, long renewLeaseThreshold, QueryPlan plan) throws
SQLException {
+ this(mutationState, scan, scanMetrics, renewLeaseThreshold, plan,
false);
+ }
+
+ public TableResultIterator(MutationState mutationState, Scan scan,
CombinableMetric scanMetrics, long renewLeaseThreshold, QueryPlan plan, boolean
handleSplitRegionBoundaryFailureDuringInitialization) throws SQLException {
this.scan = scan;
this.scanMetrics = scanMetrics;
- PTable table = tableRef.getTable();
+ PTable table = plan.getTableRef().getTable();
htable = mutationState.getHTable(table);
this.scanIterator = UNINITIALIZED_SCANNER;
this.renewLeaseThreshold = renewLeaseThreshold;
+ this.plan = plan;
+ this.handleSplitRegionBoundaryFailureDuringInitialization =
handleSplitRegionBoundaryFailureDuringInitialization;
--- End diff --
When is handleSplitRegionBoundaryFailureDuringInitialization true versus
false? Why would we *not* want to handle it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
