Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58484498
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/TableResultIterator.java
---
@@ -121,8 +170,21 @@ public synchronized void initScanner() throws
SQLException {
this.scanIterator =
new
ScanningResultIterator(htable.getScanner(scan), scanMetrics);
} catch (IOException e) {
- Closeables.closeQuietly(htable);
- throw ServerUtil.parseServerException(e);
+ if(handleSplitRegionBoundaryFailureDuringInitialization) {
--- End diff --
Rather than have a handleSplitRegionBoundaryFailureDuringInitialization,
would it work to always throw it and let the caller deal with it? When a
variable name gets beyond 50 characters, it's a sign that it may be too special
of a case. :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
