[
https://issues.apache.org/jira/browse/PHOENIX-2822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15230516#comment-15230516
]
ASF GitHub Bot commented on PHOENIX-2822:
-----------------------------------------
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/158#discussion_r58903054
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/memory/GlobalMemoryManager.java
---
@@ -94,6 +85,20 @@ private long allocateBytes(long minBytes, long reqBytes)
{
return nBytes;
}
+ @VisibleForTesting void waitForBytesToFree(long minBytes, long
startTimeMs) {
--- End diff --
Minor nit: Missing line carriage after @VisibleForTesting
> Tests that extend BaseHBaseManagedTimeIT are very slow
> ------------------------------------------------------
>
> Key: PHOENIX-2822
> URL: https://issues.apache.org/jira/browse/PHOENIX-2822
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 4.8.0
> Reporter: churro morales
> Assignee: churro morales
> Labels: HBASEDEPENDENCIES
>
> Since I am trying to refactor out all the hbase private dependencies, I have
> to constantly run tests to make sure I didn't break anything. The tests that
> extend BaseHBaseManagedTimeIT are very slow as they have to delete all
> non-system tables after every test case. This takes around 5-10 seconds to
> accomplish. This adds significant time to the test suite.
> I created a new class named: BaseHBaseManagedTimeTableReuseIT and it creates
> a random table name such that we dont have collisions for tests. It also
> doesn't do any cleanup after each test case or class because these table
> names should be unique. I moved about 30-35 tests out from
> BaseHBaseManagedTimeIT to BaseHBaseManagedTimeTableReuseIT and it
> significantly improved the overall time it takes to run tests.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
