[ 
https://issues.apache.org/jira/browse/PHOENIX-2822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15232955#comment-15232955
 ] 

ASF GitHub Bot commented on PHOENIX-2822:
-----------------------------------------

Github user churrodog commented on the pull request:

    https://github.com/apache/phoenix/pull/158#issuecomment-207610636
  
    @samarthjain rebased and put patch up here: 
https://issues.apache.org/jira/browse/PHOENIX-2822 .  Thanks for the review.


> Tests that extend BaseHBaseManagedTimeIT are very slow
> ------------------------------------------------------
>
>                 Key: PHOENIX-2822
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2822
>             Project: Phoenix
>          Issue Type: Improvement
>    Affects Versions: 4.8.0
>            Reporter: churro morales
>            Assignee: churro morales
>              Labels: HBASEDEPENDENCIES
>         Attachments: PHOENIX-2822.patch
>
>
> Since I am trying to refactor out all the hbase private dependencies, I have 
> to constantly run tests to make sure I didn't break anything.  The tests that 
> extend BaseHBaseManagedTimeIT are very slow as they have to delete all 
> non-system tables after every test case.  This takes around 5-10 seconds to 
> accomplish.  This adds significant time to the test suite. 
> I created a new class named: BaseHBaseManagedTimeTableReuseIT and it creates 
> a random table name such that we dont have collisions for tests.  It also 
> doesn't do any cleanup after each test case or class because these table 
> names should be unique.  I moved about 30-35 tests out from 
> BaseHBaseManagedTimeIT to BaseHBaseManagedTimeTableReuseIT and it 
> significantly improved the overall time it takes to run tests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to