[
https://issues.apache.org/jira/browse/PHOENIX-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15232766#comment-15232766
]
ASF GitHub Bot commented on PHOENIX-2628:
-----------------------------------------
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r59077319
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/BaseScannerRegionObserver.java
---
@@ -279,6 +301,31 @@ protected RegionScanner getWrappedScanner(final
ObserverContext<RegionCoprocesso
final ImmutableBytesWritable ptr) {
return new RegionScanner() {
+ private boolean hasReferences = checkForReferenceFiles();
+ private HRegionInfo regionInfo =
c.getEnvironment().getRegionInfo();
+ private byte[] actualStartKey = getActualStartKey();
+
+ private boolean checkForReferenceFiles(){
--- End diff --
Added the code comments and checking references is not expensive. We need
to do this for local indexes case only.
> Ensure split when iterating through results handled correctly
> -------------------------------------------------------------
>
> Key: PHOENIX-2628
> URL: https://issues.apache.org/jira/browse/PHOENIX-2628
> Project: Phoenix
> Issue Type: Bug
> Reporter: James Taylor
> Assignee: Rajeshbabu Chintaguntla
> Fix For: 4.8.0
>
> Attachments: PHOENIX-2628-wip.patch, PHOENIX-2628.patch,
> PHOENIX-2628_v7.patch, PHOENIX-2628_v8.patch
>
>
> We should start with a test case to ensure this works correctly, both for
> scans and aggregates.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
