[
https://issues.apache.org/jira/browse/PHOENIX-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15232836#comment-15232836
]
ASF GitHub Bot commented on PHOENIX-2628:
-----------------------------------------
Github user chrajeshbabu commented on the pull request:
https://github.com/apache/phoenix/pull/156#issuecomment-207582047
@JamesRTaylor Thanks for the review. Committed the changes handling the
review comments.
Refactored the code and added code comments where ever possible.
Now not handling the special cases required for ChunkedResultItertor.
bq. Another potential, different approach would be for Phoenix to
universally handle the split during scan case (rather than letting the HBase
client scanner handle it for non aggregate case and Phoenix handle it for the
aggregate case). Would that simplify things?
Now throwing stale region bound exception all the cases when ever we get
NSRE then phoenix client can handle the NSRE than hbase client handling with
wrong region boundaries.
The ordered aggregate queries issue you are mentioning can be handled as
part of other issue.
Please review the latest code.
Thanks.
> Ensure split when iterating through results handled correctly
> -------------------------------------------------------------
>
> Key: PHOENIX-2628
> URL: https://issues.apache.org/jira/browse/PHOENIX-2628
> Project: Phoenix
> Issue Type: Bug
> Reporter: James Taylor
> Assignee: Rajeshbabu Chintaguntla
> Fix For: 4.8.0
>
> Attachments: PHOENIX-2628-wip.patch, PHOENIX-2628.patch,
> PHOENIX-2628_v7.patch, PHOENIX-2628_v8.patch
>
>
> We should start with a test case to ensure this works correctly, both for
> scans and aggregates.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
