Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/168#discussion_r62699657
  
    --- Diff: 
phoenix-core/src/main/java/org/apache/phoenix/iterate/ExplainTable.java ---
    @@ -198,8 +198,14 @@ private void appendPKColumnValue(StringBuilder buf, 
byte[] range, Boolean isNull
                 type.coerceBytes(ptr, type, sortOrder, SortOrder.getDefault());
                 range = ptr.get();
             }
    -        Format formatter = context.getConnection().getFormatter(type);
    -        buf.append(type.toStringLiteral(range, formatter));
    +        if (changeViewIndexId) {
    --- End diff --
    
    I like this trick. We should always do this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to