Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/168#discussion_r63463482
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/index/IndexMaintainer.java ---
@@ -861,7 +871,12 @@ public Put buildUpdateMutation(KeyValueBuilder
kvBuilder, ValueGetter valueGette
put.setDurability(!indexWALDisabled ?
Durability.USE_DEFAULT : Durability.SKIP_WAL);
}
//this is a little bit of extra work for installations
that are running <0.94.14, but that should be rare and is a short-term set of
wrappers - it shouldn't kill GC
- put.add(kvBuilder.buildPut(rowKey,
ref.getFamilyWritable(), cq, ts, value));
+ if(this.isLocalIndex) {
+ ColumnReference columnReference =
this.coveredColumnsMap.get(ref);
+ put.add(kvBuilder.buildPut(rowKey,
columnReference.getFamilyWritable(), cq, ts, value));
--- End diff --
Yes James. It's to save regenerating the column family name all the time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
