Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/168#discussion_r63469452
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/util/IndexUtil.java 
---
    @@ -667,4 +651,28 @@ public static String 
getIndexColumnExpressionStr(PColumn col) {
             return col.getExpressionStr() == null ? 
IndexUtil.getCaseSensitiveDataColumnFullName(col.getName().getString())
                     : col.getExpressionStr();
         }
    +
    +    public static void 
addLocalUpdatesToCpOperations(ObserverContext<RegionCoprocessorEnvironment> c,
    --- End diff --
    
    Minor nit, but if this is called in only one place, can we move this there 
and make it private?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to