[ 
https://issues.apache.org/jira/browse/PHOENIX-2914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15292573#comment-15292573
 ] 

Josh Elser commented on PHOENIX-2914:
-------------------------------------

bq. we already have the code that sets to the path /etc/hbase/conf in case if 
there is no HBASE_HOME in the env. It was done in PHOENIX-2449. Josh Elser, 
Enis Soztutar any thoughts?

The convention of checking bin/ directory seems to be consistent enough (a 
little non-standard at first glance to me, but it works). The patch seems a bit 
duplicative WRT what phoenix_utils.py is doing, but it's not inherently bad 
either.

> Make sqlline refer to bin/hbase-site.xml by default
> ---------------------------------------------------
>
>                 Key: PHOENIX-2914
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2914
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Junegunn Choi
>            Priority: Minor
>         Attachments: PHOENIX-2914.patch
>
>
> I expected sqlline to pick up the settings in {{bin/hbase-site.xml}} by 
> default, but it didn't unless I set up {{HBASE_CONF_DIR}} to point to the 
> {{bin}} directory.
> An easy solution would be to simply prepend {{hbase_config_path}} to the 
> classpath. {{hbase_config_path}} and {{phoenix_utils.hbase_conf_dir}} will 
> point to the same directory when {{HBASE_CONF_DIR}} is set, but having it 
> twice in classpath will not cause any problem.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to