[
https://issues.apache.org/jira/browse/PHOENIX-2914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15298125#comment-15298125
]
Ankit Singhal commented on PHOENIX-2914:
----------------------------------------
Sorry to pitch in late, but I'm facing problem to update config at multiple
places after the above change.
IMHO, We can delete bin/hbase-site.xml , if it is confusing a user and update
hbase_config_path to use phoenix_utils.hbase_conf_dir only.
If at all, we require some config to be overridden for phoenix client , we may
introduce PHOENIX_CONF_DIR or something to override cluster values. but we
should keep only one hbase config path in java classpath.
{code}
-hbase_config_path = os.getenv('HBASE_CONF_DIR', phoenix_utils.current_dir)
+hbase_config_path = phoenix_utils.hbase_conf_dir
- ' -cp "' + hbase_config_path + os.pathsep + phoenix_utils.hbase_conf_dir +
os.pathsep + phoenix_utils.phoenix_client_jar + os.pathsep +
phoenix_utils.hadoop_common_jar + os.pathsep + phoenix_utils.hadoop_hdfs_jar + \
+ ' -cp "' + hbase_config_path + os.pathsep +
phoenix_utils.phoenix_client_jar + os.pathsep + phoenix_utils.hadoop_common_jar
+ os.pathsep + phoenix_utils.hadoop_hdfs_jar + \
{code}
And, also in any case we should keep psql.py also consistent.
> Make sqlline refer to bin/hbase-site.xml by default
> ---------------------------------------------------
>
> Key: PHOENIX-2914
> URL: https://issues.apache.org/jira/browse/PHOENIX-2914
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Junegunn Choi
> Priority: Minor
> Fix For: 4.8.0
>
> Attachments: PHOENIX-2914.patch
>
>
> I expected sqlline to pick up the settings in {{bin/hbase-site.xml}} by
> default, but it didn't unless I set up {{HBASE_CONF_DIR}} to point to the
> {{bin}} directory.
> An easy solution would be to simply prepend {{hbase_config_path}} to the
> classpath. {{hbase_config_path}} and {{phoenix_utils.hbase_conf_dir}} will
> point to the same directory when {{HBASE_CONF_DIR}} is set, but having it
> twice in classpath will not cause any problem.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
