[ 
https://issues.apache.org/jira/browse/PHOENIX-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15308866#comment-15308866
 ] 

Mujtaba Chohan commented on PHOENIX-2535:
-----------------------------------------

Few minor issues at quick glance in 
[PHOENIX-2535-6.patch|https://issues.apache.org/jira/secure/attachment/12806600/PHOENIX-2535-6.patch]

phoenix-client-4.8.0-HBase-1.2-SNAPSHOT.jar still getting generated:
{code}
phoenix-client/target$ ll *.jar
100975598 phoenix-4.8.0-HBase-1.2-SNAPSHOT-client.jar
13383 phoenix-client-4.8.0-HBase-1.2-SNAPSHOT.jar
{code}

Directories/files that should be marked for delete:
{code}
phoenix-assembly/src/build/client.xml
phoenix-assembly/src/build/client-spark.xml
phoenix-assembly/src/build/server.xml
phoenix-server
phoenix-server-client
{code}

Will try out the patch by deploying it on server as well.

> Create shaded clients (thin + thick) 
> -------------------------------------
>
>                 Key: PHOENIX-2535
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2535
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Enis Soztutar
>            Assignee: Sergey Soldatov
>             Fix For: 4.8.0
>
>         Attachments: PHOENIX-2535-1.patch, PHOENIX-2535-2.patch, 
> PHOENIX-2535-3.patch, PHOENIX-2535-4.patch, PHOENIX-2535-5.patch, 
> PHOENIX-2535-6.patch
>
>
> Having shaded client artifacts helps greatly in minimizing the dependency 
> conflicts at the run time. We are seeing more of Phoenix JDBC client being 
> used in Storm topologies and other settings where guava versions become a 
> problem. 
> I think we can do a parallel artifact for the thick client with shaded 
> dependencies and also using shaded hbase. For thin client, maybe shading 
> should be the default since it is new? 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to