[ 
https://issues.apache.org/jira/browse/PHOENIX-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15318680#comment-15318680
 ] 

ASF GitHub Bot commented on PHOENIX-2535:
-----------------------------------------

Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/159#discussion_r66094042
  
    --- Diff: phoenix-server/pom.xml ---
    @@ -7,52 +30,98 @@
         <version>4.8.0-HBase-1.2-SNAPSHOT</version>
       </parent>
       <artifactId>phoenix-server</artifactId>
    -  <name>Phoenix Query Server</name>
    -  <description>A query server for exposing Phoenix to thin 
clients</description>
    -
    -  <licenses>
    -    <license>
    -      <name>The Apache Software License, Version 2.0</name>
    -      <url>http://www.apache.org/licenses/LICENSE-2.0.txt</url>
    -      <distribution>repo</distribution>
    -      <comments />
    -    </license>
    -  </licenses>
    -
    -  <organization>
    -    <name>Apache Software Foundation</name>
    -    <url>http://www.apache.org</url>
    -  </organization>
    -
    +  <name>Phoenix Server</name>
    +  <description>Phoenix Server</description>
    --- End diff --
    
    Nit: A better description would be awesome


> Create shaded clients (thin + thick) 
> -------------------------------------
>
>                 Key: PHOENIX-2535
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2535
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Enis Soztutar
>            Assignee: Sergey Soldatov
>             Fix For: 4.8.0
>
>         Attachments: PHOENIX-2535-1.patch, PHOENIX-2535-2.patch, 
> PHOENIX-2535-3.patch, PHOENIX-2535-4.patch, PHOENIX-2535-5.patch, 
> PHOENIX-2535-6.patch, PHOENIX-2535-7.patch
>
>
> Having shaded client artifacts helps greatly in minimizing the dependency 
> conflicts at the run time. We are seeing more of Phoenix JDBC client being 
> used in Storm topologies and other settings where guava versions become a 
> problem. 
> I think we can do a parallel artifact for the thick client with shaded 
> dependencies and also using shaded hbase. For thin client, maybe shading 
> should be the default since it is new? 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to