[
https://issues.apache.org/jira/browse/PHOENIX-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15318749#comment-15318749
]
ASF GitHub Bot commented on PHOENIX-2535:
-----------------------------------------
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/159#discussion_r66099747
--- Diff: bin/queryserver.py ---
@@ -119,7 +119,7 @@
# The command is run through subprocess so environment variables are
automatically inherited
java_cmd = '%(java)s -cp ' + hbase_config_path + os.pathsep +
hadoop_config_path + os.pathsep + \
- phoenix_utils.phoenix_queryserver_jar + os.pathsep +
phoenix_utils.phoenix_client_jar + \
+ phoenix_utils.phoenix_client_jar + \
--- End diff --
Right, realized that later :). Given my opinion on removing the queryserver
classes from the client jar, I think this should be switched back to
queryserver + client. It makes a more natural usage, IMO.
> Create shaded clients (thin + thick)
> -------------------------------------
>
> Key: PHOENIX-2535
> URL: https://issues.apache.org/jira/browse/PHOENIX-2535
> Project: Phoenix
> Issue Type: Bug
> Reporter: Enis Soztutar
> Assignee: Sergey Soldatov
> Fix For: 4.8.0
>
> Attachments: PHOENIX-2535-1.patch, PHOENIX-2535-2.patch,
> PHOENIX-2535-3.patch, PHOENIX-2535-4.patch, PHOENIX-2535-5.patch,
> PHOENIX-2535-6.patch, PHOENIX-2535-7.patch
>
>
> Having shaded client artifacts helps greatly in minimizing the dependency
> conflicts at the run time. We are seeing more of Phoenix JDBC client being
> used in Storm topologies and other settings where guava versions become a
> problem.
> I think we can do a parallel artifact for the thick client with shaded
> dependencies and also using shaded hbase. For thin client, maybe shading
> should be the default since it is new?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
